Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic to skip Youtube test on-demand #401

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 26, 2024

Fix #398

Since Youtube test might be flaky due to environmental constraints, let's add an option to skip it.

@benoit74 benoit74 self-assigned this Sep 26, 2024
@benoit74 benoit74 force-pushed the skip_youtube_test branch 8 times, most recently from f8515c4 to 84650e1 Compare September 26, 2024 10:16
@benoit74
Copy link
Collaborator Author

@benoit74 benoit74 marked this pull request as ready for review September 26, 2024 10:43
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the GH variable thing which I'd prefer in the workflow. I'll let you decide

.github/workflows/DailyTests.yaml Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit f17e152 into main Sep 27, 2024
6 checks passed
@benoit74 benoit74 deleted the skip_youtube_test branch September 27, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily CI is failing
2 participants